Commit 5987dfde authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Luca Coelho
Browse files

iwlwifi: fw: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 84caa1dd

drivers/net/wireless/intel/iwlwifi/fw/debugfs.c

+3 −8
Original line number Diff line number Diff line
@@ -173,9 +173,8 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ 
	_FWRT_DEBUGFS_READ_WRITE_FILE_OPS(name, bufsz, struct iwl_fw_runtime)



#define FWRT_DEBUGFS_ADD_FILE_ALIAS(alias, name, parent, mode) do {	\

	if (!debugfs_create_file(alias, mode, parent, fwrt,		\

				 &iwl_dbgfs_##name##_ops))		\

		goto err;						\

	debugfs_create_file(alias, mode, parent, fwrt,			\

			    &iwl_dbgfs_##name##_ops);			\

	} while (0)

#define FWRT_DEBUGFS_ADD_FILE(name, parent, mode) \

	FWRT_DEBUGFS_ADD_FILE_ALIAS(#name, name, parent, mode)
@@ -321,14 +320,10 @@ out: 


FWRT_DEBUGFS_WRITE_FILE_OPS(send_hcmd, 512);



int iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,

void iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,

			    struct dentry *dbgfs_dir)

{

	INIT_DELAYED_WORK(&fwrt->timestamp.wk, iwl_fw_timestamp_marker_wk);

	FWRT_DEBUGFS_ADD_FILE(timestamp_marker, dbgfs_dir, 0200);

	FWRT_DEBUGFS_ADD_FILE(send_hcmd, dbgfs_dir, 0200);

	return 0;

err:

	IWL_ERR(fwrt, "Can't create the fwrt debugfs directory\n");

	return -ENOMEM;

}

drivers/net/wireless/intel/iwlwifi/fw/debugfs.h

+3 −6
Original line number Diff line number Diff line
@@ -63,14 +63,11 @@ 
#include "runtime.h"



#ifdef CONFIG_IWLWIFI_DEBUGFS

int iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,

void iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,

			    struct dentry *dbgfs_dir);



#else

static inline int iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,

					  struct dentry *dbgfs_dir)

{

	return 0;

}

static inline void iwl_fwrt_dbgfs_register(struct iwl_fw_runtime *fwrt,

					   struct dentry *dbgfs_dir) { }



#endif /* CONFIG_IWLWIFI_DEBUGFS */

CRA Git | Maintained and supported by SUSTech CRA and CCSE