Commit dbb988b4 authored Jun 28, 2020 by Wei Yongjun Committed by Stephen Boyd Jun 29, 2020

clk: qcom: Fix return value check in apss_ipq6018_probe()



In case of error, the function dev_get_regmap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 5e77b4ef ("clk: qcom: Add ipq6018 apss clock controller")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20200628023055.50608-1-weiyongjun1@huawei.com


Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 59390282

drivers/clk/qcom/apss-ipq6018.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -87,8 +87,8 @@ static int apss_ipq6018_probe(struct platform_device *pdev)
		struct regmap *regmap;

		regmap = dev_get_regmap(pdev->dev.parent, NULL);
		if (IS_ERR(regmap))
		return PTR_ERR(regmap);
		if (!regmap)
		return -ENODEV;

		return qcom_cc_really_probe(pdev, &apss_ipq6018_desc, regmap);
		}

Admin message