Commit da206d65 authored Mar 19, 2020 by Vladimir Oltean Committed by David S. Miller Mar 23, 2020

net: phy: mscc: accept all RGMII species in vsc85xx_mac_if_set



The helper for configuring the pinout of the MII side of the PHY should
do so irrespective of whether RGMII delays are used or not. So accept
the ID, TXID and RXID variants as well, not just the no-delay RGMII
variant.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4035e812

drivers/net/phy/mscc/mscc_main.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -491,6 +491,9 @@ static int vsc85xx_mac_if_set(struct phy_device *phydev,
		reg_val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1);
		reg_val &= ~(MAC_IF_SELECTION_MASK);
		switch (interface) {
		case PHY_INTERFACE_MODE_RGMII_TXID:
		case PHY_INTERFACE_MODE_RGMII_RXID:
		case PHY_INTERFACE_MODE_RGMII_ID:
		case PHY_INTERFACE_MODE_RGMII:
		reg_val \|= (MAC_IF_SELECTION_RGMII << MAC_IF_SELECTION_POS);
		break;

Admin message