Commit d54a16b2 authored May 02, 2019 by Michal Kubecek Committed by David S. Miller May 04, 2019

netlink: set bad attribute also on maxtype check



The check that attribute type is within 0...maxtype range in
__nla_validate_parse() sets only error message but not bad_attr in extack.
Set also bad_attr to tell userspace which attribute failed validation.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 05d7f547

lib/nlattr.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -356,7 +356,8 @@ static int __nla_validate_parse(const struct nlattr *head, int len, int maxtype,

		if (type == 0 \|\| type > maxtype) {
		if (validate & NL_VALIDATE_MAXTYPE) {
		NL_SET_ERR_MSG(extack, "Unknown attribute type");
		NL_SET_ERR_MSG_ATTR(extack, nla,
		"Unknown attribute type");
		return -EINVAL;
		}
		continue;

Admin message