Commit 05d7f547 authored May 02, 2019 by Michal Kubecek Committed by David S. Miller May 04, 2019

genetlink: do not validate dump requests if there is no policy



Unlike do requests, dump genetlink requests now perform strict validation
by default even if the genetlink family does not set policy and maxtype
because it does validation and parsing on its own (e.g. because it wants to
allow different message format for different commands). While the null
policy will be ignored, maxtype (which would be zero) is still checked so
that any attribute will fail validation.

The solution is to only call __nla_validate() from genl_family_rcv_msg()
if family->maxtype is set.

Fixes: ef6243ac ("genetlink: optionally validate strictly/dumps")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5eabc27d

net/netlink/genetlink.c

+14 −10

Original line number	Diff line number	Diff line
		@@ -537,22 +537,26 @@ static int genl_family_rcv_msg(const struct genl_family *family,
		return -EOPNOTSUPP;

		if (!(ops->validate & GENL_DONT_VALIDATE_DUMP)) {
		unsigned int validate = NL_VALIDATE_STRICT;
		int hdrlen = GENL_HDRLEN + family->hdrsize;

		if (ops->validate & GENL_DONT_VALIDATE_DUMP_STRICT)
		validate = NL_VALIDATE_LIBERAL;

		if (nlh->nlmsg_len < nlmsg_msg_size(hdrlen))
		return -EINVAL;

		if (family->maxattr) {
		unsigned int validate = NL_VALIDATE_STRICT;

		if (ops->validate &
		GENL_DONT_VALIDATE_DUMP_STRICT)
		validate = NL_VALIDATE_LIBERAL;
		rc = __nla_validate(nlmsg_attrdata(nlh, hdrlen),
		nlmsg_attrlen(nlh, hdrlen),
		family->maxattr, family->policy,
		family->maxattr,
		family->policy,
		validate, extack);
		if (rc)
		return rc;
		}
		}

		if (!family->parallel_ops) {
		struct netlink_dump_control c = {

Admin message