Commit d432d045 authored Aug 04, 2019 by Nishka Dasgupta Committed by Stephen Boyd Aug 07, 2019

clk: st: clk-flexgen: Add of_node_put() in st_of_flexgen_setup()



In function st_of_flexgen_setup, variable pnode takes the return value
of of_get_parent, which gets a node but does not put it. If pnode is not
put before the function returns, it may cause a memory leak. Hence put
pnode after its last occurrence.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lkml.kernel.org/r/20190804163151.6511-1-nishkadg.linux@gmail.com


Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent d55841ce

drivers/clk/st/clk-flexgen.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -326,6 +326,7 @@ static void __init st_of_flexgen_setup(struct device_node *np)
		return;

		reg = of_iomap(pnode, 0);
		of_node_put(pnode);
		if (!reg)
		return;

Admin message