Commit d55841ce authored Aug 04, 2019 by Nishka Dasgupta Committed by Stephen Boyd Aug 07, 2019

clk: davinci: pll: Add of_node_put() in of_davinci_pll_init()



The variable child in the function of_davinci_pll_init takes the value
of of_get_child_by_name, which gets a node but does not put it. If child
is not put before the function returns it may cause a memory leak. Hence
put child before two return statements.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lkml.kernel.org/r/20190804162824.6338-1-nishkadg.linux@gmail.com


Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 5911dba5

drivers/clk/davinci/pll.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -778,12 +778,15 @@ int of_davinci_pll_init(struct device dev, struct device_node node,
		int i;

		clk_data = kzalloc(sizeof(*clk_data), GFP_KERNEL);
		if (!clk_data)
		if (!clk_data) {
		of_node_put(child);
		return -ENOMEM;
		}

		clks = kmalloc_array(n_clks, sizeof(*clks), GFP_KERNEL);
		if (!clks) {
		kfree(clk_data);
		of_node_put(child);
		return -ENOMEM;
		}

Admin message