Commit d2249bf2 authored Aug 27, 2020 by Jing Xiangfeng Committed by Stephen Boyd Sep 10, 2020

clk: qcom: lpass: Correct goto target in lpass_core_sc7180_probe()

lpass_core_sc7180_probe() misses to call pm_clk_destroy() and
pm_runtime_disable() in error paths. Correct goto target to fix it.
This issue is found by code inspection.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Link: https://lore.kernel.org/r/20200827141629.101802-1-jingxiangfeng@huawei.com

Fixes: edab812d ("clk: qcom: lpass: Add support for LPASS clock controller for SC7180")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent da9c43dc

drivers/clk/qcom/lpasscorecc-sc7180.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -420,17 +420,18 @@ static int lpass_core_sc7180_probe(struct platform_device *pdev)
		pm_runtime_enable(&pdev->dev);
		ret = pm_clk_create(&pdev->dev);
		if (ret)
		return ret;
		goto disable_pm_runtime;

		ret = pm_clk_add(&pdev->dev, "iface");
		if (ret < 0) {
		dev_err(&pdev->dev, "failed to acquire iface clock\n");
		goto disable_pm_runtime;
		goto destroy_pm_clk;
		}

		ret = -EINVAL;
		clk_probe = of_device_get_match_data(&pdev->dev);
		if (!clk_probe)
		return -EINVAL;
		goto destroy_pm_clk;

		ret = clk_probe(pdev);
		if (ret)