Commit da9c43dc authored Aug 29, 2020 by Sumera Priyadarsini Committed by Stephen Boyd Sep 10, 2020

clk: versatile: Add of_node_put() before return statement



Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin


Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 73a203b0

drivers/clk/versatile/clk-impd1.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -109,9 +109,11 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev)

		for_each_available_child_of_node(np, child) {
		ret = integrator_impd1_clk_spawn(dev, np, child);
		if (ret)
		if (ret) {
		of_node_put(child);
		break;
		}
		}

		return ret;
		}

Admin message