Commit d10dcb61 authored Oct 04, 2019 by Navid Emamdoost Committed by Kalle Valo Oct 09, 2019

mwifiex: pcie: Fix memory leak in mwifiex_pcie_init_evt_ring



In mwifiex_pcie_init_evt_ring, a new skb is allocated which should be
released if mwifiex_map_pci_memory() fails. The release for skb and
card->evtbd_ring_vbase is added.

Fixes: 0732484b ("mwifiex: separate ring initialization and ring creation routines")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Ganapathi Bhat <gbhat@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent db8fd2cd

drivers/net/wireless/marvell/mwifiex/pcie.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -687,8 +687,11 @@ static int mwifiex_pcie_init_evt_ring(struct mwifiex_adapter *adapter)
		skb_put(skb, MAX_EVENT_SIZE);

		if (mwifiex_map_pci_memory(adapter, skb, MAX_EVENT_SIZE,
		PCI_DMA_FROMDEVICE))
		PCI_DMA_FROMDEVICE)) {
		kfree_skb(skb);
		kfree(card->evtbd_ring_vbase);
		return -1;
		}

		buf_pa = MWIFIEX_SKB_DMA_ADDR(skb);

Admin message