Commit db8fd2cd authored Oct 04, 2019 by Navid Emamdoost Committed by Kalle Valo Oct 09, 2019

mwifiex: pcie: Fix memory leak in mwifiex_pcie_alloc_cmdrsp_buf



In mwifiex_pcie_alloc_cmdrsp_buf, a new skb is allocated which should be
released if mwifiex_map_pci_memory() fails. The release is added.

Fixes: fc331460 ("mwifiex: use pci_alloc/free_consistent APIs for PCIe")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Acked-by: Ganapathi Bhat <gbhat@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 39e50f5c

drivers/net/wireless/marvell/mwifiex/pcie.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1029,8 +1029,10 @@ static int mwifiex_pcie_alloc_cmdrsp_buf(struct mwifiex_adapter *adapter)
		}
		skb_put(skb, MWIFIEX_UPLD_SIZE);
		if (mwifiex_map_pci_memory(adapter, skb, MWIFIEX_UPLD_SIZE,
		PCI_DMA_FROMDEVICE))
		PCI_DMA_FROMDEVICE)) {
		kfree_skb(skb);
		return -1;
		}

		card->cmdrsp_buf = skb;

Admin message