Commit cfd1d0f5 authored Dec 01, 2020 by Dan Carpenter Committed by Dominique Martinet Dec 01, 2020

9p: Remove unnecessary IS_ERR() check



The "fid" variable can't be an error pointer so there is no need to
check.  The code is slightly cleaner if we move the increment before
the break and remove the NULL check as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>

parent dfd37586

fs/9p/fid.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -56,12 +56,11 @@ static struct p9_fid v9fs_fid_find_inode(struct inode inode, kuid_t uid)
		h = (struct hlist_head *)&inode->i_private;
		hlist_for_each_entry(fid, h, ilist) {
		if (uid_eq(fid->uid, uid)) {
		refcount_inc(&fid->count);
		ret = fid;
		break;
		}
		}
		if (ret && !IS_ERR(ret))
		refcount_inc(&ret->count);
		spin_unlock(&inode->i_lock);
		return ret;
		}

Admin message