Commit dfd37586 authored Nov 30, 2020 by Dan Carpenter Committed by Dominique Martinet Dec 01, 2020

9p: Uninitialized variable in v9fs_writeback_fid()



If v9fs_fid_lookup_with_uid() fails then "fid" is not initialized.

The v9fs_fid_lookup_with_uid() can't return NULL.  If it returns an
error pointer then we can still pass that to clone_fid() and it will
return the error pointer back again.

Fixes: 6636b6dc ("9p: add refcount to p9_fid struct")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>

parent 5bfe97d7

fs/9p/fid.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -302,7 +302,6 @@ struct p9_fid v9fs_writeback_fid(struct dentry dentry)
		struct p9_fid fid, ofid;

		ofid = v9fs_fid_lookup_with_uid(dentry, GLOBAL_ROOT_UID, 0);
		if (ofid && !IS_ERR(ofid))
		fid = clone_fid(ofid);
		if (IS_ERR(fid))
		goto error_out;

Admin message