Commit cefe6aac authored by Hans de Goede's avatar Hans de Goede Committed by Rafael J. Wysocki
Browse files

ACPI / PMIC: Add Cherry Trail Crystal Cove PMIC OpRegion driver 



We have no docs for the CHT Crystal Cove PMIC. The Asus Zenfone-2 kernel
code has 2 Crystal Cove regulator drivers, one calls the PMIC a "Crystal
Cove Plus" PMIC and talks about Cherry Trail, so presuambly that one
could be used to get register info for the regulators if we need to
implement regulator support in the future.

For now the sole purpose of this driver is to make
intel_soc_pmic_exec_mipi_pmic_seq_element work on devices with a
CHT Crystal Cove PMIC.

Specifically this fixes the following MIPI PMIC sequence related errors
on e.g. an Asus T100HA:

[  178.211801] intel_soc_pmic_exec_mipi_pmic_seq_element: No PMIC registered
[  178.211897] [drm:intel_dsi_dcs_init_backlight_funcs [i915]] *ERROR* mipi_exec_pmic failed, error: -6

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent ed852cde

drivers/acpi/Kconfig

+7 −0
Original line number Diff line number Diff line
@@ -520,6 +520,13 @@ config BYTCRC_PMIC_OPREGION 
	  This config adds ACPI operation region support for the Bay Trail

	  version of the Crystal Cove PMIC.



config CHTCRC_PMIC_OPREGION

	bool "ACPI operation region support for Cherry Trail Crystal Cove PMIC"

	depends on INTEL_SOC_PMIC

	help

	  This config adds ACPI operation region support for the Cherry Trail

	  version of the Crystal Cove PMIC.



config XPOWER_PMIC_OPREGION

	bool "ACPI operation region support for XPower AXP288 PMIC"

	depends on MFD_AXP20X_I2C && IOSF_MBI=y

drivers/acpi/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -110,6 +110,7 @@ obj-$(CONFIG_ACPI_EXTLOG) += acpi_extlog.o 


obj-$(CONFIG_PMIC_OPREGION)	+= pmic/intel_pmic.o

obj-$(CONFIG_BYTCRC_PMIC_OPREGION) += pmic/intel_pmic_bytcrc.o

obj-$(CONFIG_CHTCRC_PMIC_OPREGION) += pmic/intel_pmic_chtcrc.o

obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o

obj-$(CONFIG_BXT_WC_PMIC_OPREGION) += pmic/intel_pmic_bxtwc.o

obj-$(CONFIG_CHT_WC_PMIC_OPREGION) += pmic/intel_pmic_chtwc.o

drivers/acpi/pmic/intel_pmic_chtcrc.c

0 → 100644
+44 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * Intel Cherry Trail Crystal Cove PMIC operation region driver

 *

 * Copyright (C) 2019 Hans de Goede <hdegoede@redhat.com>

 */



#include <linux/acpi.h>

#include <linux/init.h>

#include <linux/mfd/intel_soc_pmic.h>

#include <linux/platform_device.h>

#include <linux/regmap.h>

#include "intel_pmic.h"



/*

 * We have no docs for the CHT Crystal Cove PMIC. The Asus Zenfone-2 kernel

 * code has 2 Crystal Cove regulator drivers, one calls the PMIC a "Crystal

 * Cove Plus" PMIC and talks about Cherry Trail, so presuambly that one

 * could be used to get register info for the regulators if we need to

 * implement regulator support in the future.

 *

 * For now the sole purpose of this driver is to make

 * intel_soc_pmic_exec_mipi_pmic_seq_element work on devices with a

 * CHT Crystal Cove PMIC.

 */

static struct intel_pmic_opregion_data intel_chtcrc_pmic_opregion_data = {

	.pmic_i2c_address = 0x6e,

};



static int intel_chtcrc_pmic_opregion_probe(struct platform_device *pdev)

{

	struct intel_soc_pmic *pmic = dev_get_drvdata(pdev->dev.parent);

	return intel_pmic_install_opregion_handler(&pdev->dev,

			ACPI_HANDLE(pdev->dev.parent), pmic->regmap,

			&intel_chtcrc_pmic_opregion_data);

}



static struct platform_driver intel_chtcrc_pmic_opregion_driver = {

	.probe = intel_chtcrc_pmic_opregion_probe,

	.driver = {

		.name = "cht_crystal_cove_pmic",

	},

};

builtin_platform_driver(intel_chtcrc_pmic_opregion_driver);

CRA Git | Maintained and supported by SUSTech CRA and CCSE