Commit ceeaa70c authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (emc1403) Relax hysteresis limit write checks 



Writing the hysteresis limit returned -ERANGE if the written hysteresis
was too high or too low. Relax error check and adjust the hysteresis
value to its valid range.

Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 84899d39

drivers/hwmon/emc1403.c

+1 −6
Original line number Diff line number Diff line
@@ -147,12 +147,7 @@ static ssize_t store_hyst(struct device *dev, 
		goto fail;



	hyst = limit * 1000 - val;

	hyst = DIV_ROUND_CLOSEST(hyst, 1000);

	if (hyst < 0 || hyst > 255) {

		retval = -ERANGE;

		goto fail;

	}



	hyst = clamp_val(DIV_ROUND_CLOSEST(hyst, 1000), 0, 255);

	retval = regmap_write(regmap, 0x21, hyst);

	if (retval == 0)

		retval = count;

CRA Git | Maintained and supported by SUSTech CRA and CCSE