Commit 84899d39 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (emc1403) Make all hyst attributes except for temp1_crit_hyst read-only 



All chips in this chip series only support a single hysteresis value. Having
multiple writable hysteresis attributes is therefore confusing, since a single
write affects all hysteresis temperatures. Make all but one (temp1_crit_hyst)
read-only.

Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 03f49f64

Documentation/hwmon/emc1403

+5 −2
Original line number Diff line number Diff line
@@ -51,6 +51,9 @@ This implementation detail implies the following: 
  was 80 degrees C, and the hysteresis was 75 degrees C, and you change

  the critical limit to 90 degrees C, then the hysteresis will

  automatically change to 85 degrees C.

* While hysteresis limits can be set for all critical limits, setting a single

  hysteresis value affects the hysteresis values for all limits on all sensors.

* The hysteresis values can't be set independently. We decided to make

  only temp1_crit_hyst writable, while all other hysteresis attributes

  are read-only. Setting temp1_crit_hyst writes the difference between

  temp1_crit_hyst and temp1_crit into the chip, and the same relative

  hysteresis applies automatically to all other limits.

* The limits should be set before the hysteresis.

drivers/hwmon/emc1403.c

+3 −6
Original line number Diff line number Diff line
@@ -195,8 +195,7 @@ static SENSOR_DEVICE_ATTR_2(temp2_max_alarm, S_IRUGO, 
	show_bit, NULL, 0x35, 0x02);

static SENSOR_DEVICE_ATTR_2(temp2_crit_alarm, S_IRUGO,

	show_bit, NULL, 0x37, 0x02);

static SENSOR_DEVICE_ATTR(temp2_crit_hyst, S_IRUGO | S_IWUSR,

	show_hyst, store_hyst, 0x19);

static SENSOR_DEVICE_ATTR(temp2_crit_hyst, S_IRUGO, show_hyst, NULL, 0x19);



static SENSOR_DEVICE_ATTR(temp3_min, S_IRUGO | S_IWUSR,

	show_temp, store_temp, 0x16);
@@ -212,8 +211,7 @@ static SENSOR_DEVICE_ATTR_2(temp3_max_alarm, S_IRUGO, 
	show_bit, NULL, 0x35, 0x04);

static SENSOR_DEVICE_ATTR_2(temp3_crit_alarm, S_IRUGO,

	show_bit, NULL, 0x37, 0x04);

static SENSOR_DEVICE_ATTR(temp3_crit_hyst, S_IRUGO | S_IWUSR,

	show_hyst, store_hyst, 0x1A);

static SENSOR_DEVICE_ATTR(temp3_crit_hyst, S_IRUGO, show_hyst, NULL, 0x1A);



static SENSOR_DEVICE_ATTR(temp4_min, S_IRUGO | S_IWUSR,

	show_temp, store_temp, 0x2D);
@@ -229,8 +227,7 @@ static SENSOR_DEVICE_ATTR_2(temp4_max_alarm, S_IRUGO, 
	show_bit, NULL, 0x35, 0x08);

static SENSOR_DEVICE_ATTR_2(temp4_crit_alarm, S_IRUGO,

	show_bit, NULL, 0x37, 0x08);

static SENSOR_DEVICE_ATTR(temp4_crit_hyst, S_IRUGO | S_IWUSR,

	show_hyst, store_hyst, 0x30);

static SENSOR_DEVICE_ATTR(temp4_crit_hyst, S_IRUGO, show_hyst, NULL, 0x30);



static SENSOR_DEVICE_ATTR_2(power_state, S_IRUGO | S_IWUSR,

	show_bit, store_bit, 0x03, 0x40);

CRA Git | Maintained and supported by SUSTech CRA and CCSE