Commit cda3e73a authored by Antoine Tenart's avatar Antoine Tenart Committed by Herbert Xu
Browse files

crypto: inside-secure - use the error handler for invalidation requests 



This patch reworks the way invalidation request handlers handle the
result descriptor errors, to use the common error handling function.
This improves the drivers in terms of readability and maintainability.

Suggested-by: default avatarOfer Heifetz <oferh@marvell.com>
Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ce43b2e3

drivers/crypto/inside-secure/safexcel_cipher.c

+2 −5
Original line number Diff line number Diff line
@@ -491,11 +491,8 @@ static int safexcel_handle_inv_result(struct safexcel_crypto_priv *priv, 
			break;

		}



		if (rdesc->result_data.error_code) {

			dev_err(priv->dev, "cipher: invalidate: result descriptor error (%d)\n",

				rdesc->result_data.error_code);

			*ret = -EIO;

		}

		if (likely(!*ret))

			*ret = safexcel_rdesc_check_errors(priv, rdesc);



		ndesc++;

	} while (!rdesc->last_seg);

drivers/crypto/inside-secure/safexcel_hash.c

+2 −5
Original line number Diff line number Diff line
@@ -369,11 +369,8 @@ static int safexcel_handle_inv_result(struct safexcel_crypto_priv *priv, 
		dev_err(priv->dev,

			"hash: invalidate: could not retrieve the result descriptor\n");

		*ret = PTR_ERR(rdesc);

	} else if (rdesc->result_data.error_code) {

		dev_err(priv->dev,

			"hash: invalidate: result descriptor error (%d)\n",

			rdesc->result_data.error_code);

		*ret = -EINVAL;

	} else {

		*ret = safexcel_rdesc_check_errors(priv, rdesc);

	}



	safexcel_complete(priv, ring);

CRA Git | Maintained and supported by SUSTech CRA and CCSE