Commit c9675829 authored Aug 24, 2019 by Uwe Kleine-König Committed by Thierry Reding Sep 21, 2019

pwm: fsl-ftm: Don't update the state for the caller of pwm_apply_state()



The pwm-fsl-ftm driver is one of only three PWM drivers which updates
the state for the caller of pwm_apply_state(). This might have
surprising results if the caller reuses the values expecting them to
still represent the same state.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent deb9c462

drivers/pwm/pwm-fsl-ftm.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -292,10 +292,6 @@ static int fsl_pwm_apply_config(struct fsl_pwm_chip *fpc,

		regmap_update_bits(fpc->regmap, FTM_POL, BIT(pwm->hwpwm), reg_polarity);

		newstate->period = fsl_pwm_ticks_to_ns(fpc,
		fpc->period.mod_period + 1);
		newstate->duty_cycle = fsl_pwm_ticks_to_ns(fpc, duty);

		ftm_set_write_protection(fpc);

		return 0;

Admin message