Commit c73eebc0 authored by Logan Gunthorpe's avatar Logan Gunthorpe Committed by Jens Axboe
Browse files

nvmet-tcp: Don't set the request's data_len 



It's not apprporiate for the transports to set the data_len
field of the request which is only used by the core.

In this case, just use a variable on the stack to store the
length of the sgl for comparison.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarLogan Gunthorpe <logang@deltatee.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e0bace71

drivers/nvme/target/tcp.c

+2 −4
Original line number Diff line number Diff line
@@ -813,13 +813,11 @@ free_crypto: 
static void nvmet_tcp_handle_req_failure(struct nvmet_tcp_queue *queue,

		struct nvmet_tcp_cmd *cmd, struct nvmet_req *req)

{

	size_t data_len = le32_to_cpu(req->cmd->common.dptr.sgl.length);

	int ret;



	/* recover the expected data transfer length */

	req->data_len = le32_to_cpu(req->cmd->common.dptr.sgl.length);



	if (!nvme_is_write(cmd->req.cmd) ||

	    req->data_len > cmd->req.port->inline_data_size) {

	    data_len > cmd->req.port->inline_data_size) {

		nvmet_prepare_receive_pdu(queue);

		return;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE