Commit e0bace71 authored Oct 23, 2019 by Logan Gunthorpe Committed by Jens Axboe Nov 04, 2019

nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()



None of the other transports check data_len which is verified
in core code. The function should instead check that the sgl length
is non-zero.

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent e08f2ae8

drivers/nvme/target/tcp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -320,7 +320,7 @@ static int nvmet_tcp_map_data(struct nvmet_tcp_cmd *cmd)
		struct nvme_sgl_desc *sgl = &cmd->req.cmd->common.dptr.sgl;
		u32 len = le32_to_cpu(sgl->length);

		if (!cmd->req.data_len)
		if (!len)
		return 0;

		if (sgl->type == ((NVME_SGL_FMT_DATA_DESC << 4) \|

Admin message