Commit c5397f13 authored by Stanley Chu's avatar Stanley Chu Committed by Martin K. Petersen
Browse files

scsi: ufs: Do not reset error history during host reset 



Currently UFS error history will be reset and lost during host reset flow
by ufschd_probe_hba().

Avoid resetting it so error history can be kept as complete as possible to
improve debugging.

In addition, fix a minor display error in ufshcd_print_err_hist().

[mkp: commit desc clarification]

Signed-off-by: default avatarStanley Chu <stanley.chu@mediatek.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d3c615bf

drivers/scsi/ufs/ufshcd.c

+1 −12
Original line number Diff line number Diff line
@@ -402,7 +402,7 @@ static void ufshcd_print_err_hist(struct ufs_hba *hba, 


		if (err_hist->reg[p] == 0)

			continue;

		dev_err(hba->dev, "%s[%d] = 0x%x at %lld us\n", err_name, i,

		dev_err(hba->dev, "%s[%d] = 0x%x at %lld us\n", err_name, p,

			err_hist->reg[p], ktime_to_us(err_hist->tstamp[p]));

		found = true;

	}
@@ -6689,19 +6689,8 @@ static void ufshcd_tune_unipro_params(struct ufs_hba *hba) 


static void ufshcd_clear_dbg_ufs_stats(struct ufs_hba *hba)

{

	int err_reg_hist_size = sizeof(struct ufs_err_reg_hist);



	hba->ufs_stats.hibern8_exit_cnt = 0;

	hba->ufs_stats.last_hibern8_exit_tstamp = ktime_set(0, 0);



	memset(&hba->ufs_stats.pa_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.dl_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.nl_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.tl_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.dme_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.fatal_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.auto_hibern8_err, 0, err_reg_hist_size);



	hba->req_abort_count = 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE