Commit d3c615bf authored by Stanley Chu's avatar Stanley Chu Committed by Martin K. Petersen
Browse files

scsi: ufs: Add fatal and auto-hibern8 error history 



Provide more information about fatal and auto-hibern8 errors to improve
debugging by extending existing UFS error history framework.

[mkp: typos]

Signed-off-by: default avatarStanley Chu <stanley.chu@mediatek.com>
Reviewed-by: default avatarAvri Altman <avri.altman@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 48d5b973

drivers/scsi/ufs/ufshcd.c

+10 −1
Original line number Diff line number Diff line
@@ -429,6 +429,9 @@ static void ufshcd_print_host_regs(struct ufs_hba *hba) 
	ufshcd_print_err_hist(hba, &hba->ufs_stats.nl_err, "nl_err");

	ufshcd_print_err_hist(hba, &hba->ufs_stats.tl_err, "tl_err");

	ufshcd_print_err_hist(hba, &hba->ufs_stats.dme_err, "dme_err");

	ufshcd_print_err_hist(hba, &hba->ufs_stats.fatal_err, "fatal_err");

	ufshcd_print_err_hist(hba, &hba->ufs_stats.auto_hibern8_err,

			      "auto_hibern8_err");



	ufshcd_print_clk_freqs(hba);
@@ -5439,8 +5442,10 @@ static void ufshcd_check_errors(struct ufs_hba *hba) 
{

	bool queue_eh_work = false;



	if (hba->errors & INT_FATAL_ERRORS)

	if (hba->errors & INT_FATAL_ERRORS) {

		ufshcd_update_reg_hist(&hba->ufs_stats.fatal_err, hba->errors);

		queue_eh_work = true;

	}



	if (hba->errors & UIC_ERROR) {

		hba->uic_error = 0;
@@ -5455,6 +5460,8 @@ static void ufshcd_check_errors(struct ufs_hba *hba) 
			__func__, (hba->errors & UIC_HIBERNATE_ENTER) ?

			"Enter" : "Exit",

			hba->errors, ufshcd_get_upmcrs(hba));

		ufshcd_update_reg_hist(&hba->ufs_stats.auto_hibern8_err,

				       hba->errors);

		queue_eh_work = true;

	}
@@ -6692,6 +6699,8 @@ static void ufshcd_clear_dbg_ufs_stats(struct ufs_hba *hba) 
	memset(&hba->ufs_stats.nl_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.tl_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.dme_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.fatal_err, 0, err_reg_hist_size);

	memset(&hba->ufs_stats.auto_hibern8_err, 0, err_reg_hist_size);



	hba->req_abort_count = 0;

}

drivers/scsi/ufs/ufshcd.h

+9 −1
Original line number Diff line number Diff line
@@ -414,7 +414,7 @@ struct ufs_init_prefetch { 


#define UFS_ERR_REG_HIST_LENGTH 8

/**

 * struct ufs_err_reg_hist - keeps history of uic errors

 * struct ufs_err_reg_hist - keeps history of errors

 * @pos: index to indicate cyclic buffer position

 * @reg: cyclic buffer for registers value

 * @tstamp: cyclic buffer for time stamp
@@ -436,15 +436,23 @@ struct ufs_err_reg_hist { 
 * @nl_err: tracks nl-uic errors

 * @tl_err: tracks tl-uic errors

 * @dme_err: tracks dme errors

 * @fatal_err: tracks fatal errors

 * @auto_hibern8_err: tracks auto-hibernate errors

 */

struct ufs_stats {

	u32 hibern8_exit_cnt;

	ktime_t last_hibern8_exit_tstamp;



	/* uic specific errors */

	struct ufs_err_reg_hist pa_err;

	struct ufs_err_reg_hist dl_err;

	struct ufs_err_reg_hist nl_err;

	struct ufs_err_reg_hist tl_err;

	struct ufs_err_reg_hist dme_err;



	/* fatal errors */

	struct ufs_err_reg_hist fatal_err;

	struct ufs_err_reg_hist auto_hibern8_err;

};



/**

CRA Git | Maintained and supported by SUSTech CRA and CCSE