Commit c52dcf49 authored by Rex Zhu's avatar Rex Zhu Committed by Alex Deucher
Browse files

drm/amd/pp: Avoid divide-by-zero in fan_ctrl_set_fan_speed_rpm 



The minRPM speed maybe equal to zero. so need to check
input RPM not equal to 0, otherwise cause divide-by-zero driver crash.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarRex Zhu <Rex.Zhu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b3ca0f39

drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -260,6 +260,7 @@ int smu7_fan_ctrl_set_fan_speed_rpm(struct pp_hwmgr *hwmgr, uint32_t speed) 
	if (hwmgr->thermal_controller.fanInfo.bNoFan ||

	if (hwmgr->thermal_controller.fanInfo.bNoFan ||

			(hwmgr->thermal_controller.fanInfo.

			(hwmgr->thermal_controller.fanInfo.

			ucTachometerPulsesPerRevolution == 0) ||

			ucTachometerPulsesPerRevolution == 0) ||

			speed == 0 ||

			(speed < hwmgr->thermal_controller.fanInfo.ulMinRPM) ||

			(speed < hwmgr->thermal_controller.fanInfo.ulMinRPM) ||

			(speed > hwmgr->thermal_controller.fanInfo.ulMaxRPM))

			(speed > hwmgr->thermal_controller.fanInfo.ulMaxRPM))

		return 0;

		return 0;

drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -312,6 +312,7 @@ int vega10_fan_ctrl_set_fan_speed_rpm(struct pp_hwmgr *hwmgr, uint32_t speed) 
	int result = 0;

	int result = 0;





	if (hwmgr->thermal_controller.fanInfo.bNoFan ||

	if (hwmgr->thermal_controller.fanInfo.bNoFan ||

	    speed == 0 ||

	    (speed < hwmgr->thermal_controller.fanInfo.ulMinRPM) ||

	    (speed < hwmgr->thermal_controller.fanInfo.ulMinRPM) ||

	    (speed > hwmgr->thermal_controller.fanInfo.ulMaxRPM))

	    (speed > hwmgr->thermal_controller.fanInfo.ulMaxRPM))

		return -1;

		return -1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE