media: mtk-vpu: fix two smatch warnings (c4abb192) · Commits · 戴 / test

Drop the "id >= 0" test in two conditions to fix these warnings: drivers/media/platform/mtk-vpu/mtk_vpu.c:276 vpu_ipi_register() warn: always true condition '(id >= 0) => (0-u32max >= 0)' drivers/media/platform/mtk-vpu/mtk_vpu.c:401 vpu_wdt_reg_handler() warn: always true condition '(id >= 0) => (0-u32max >= 0)' Signed-off-by:

Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:

Mauro Carvalho Chehab <mchehab@kernel.org>

drivers/media/platform/mtk-vpu/mtk_vpu.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -273,7 +273,7 @@ int vpu_ipi_register(struct platform_device *pdev,
		return -EPROBE_DEFER;
		}

		if (id >= 0 && id < IPI_MAX && handler) {
		if (id < IPI_MAX && handler) {
		ipi_desc = vpu->ipi_desc;
		ipi_desc[id].name = name;
		ipi_desc[id].handler = handler;
		@@ -398,7 +398,7 @@ int vpu_wdt_reg_handler(struct platform_device *pdev,

		handler = vpu->wdt.handler;

		if (id >= 0 && id < VPU_RST_MAX && wdt_reset) {
		if (id < VPU_RST_MAX && wdt_reset) {
		dev_dbg(vpu->dev, "wdt register id %d\n", id);
		mutex_lock(&vpu->vpu_mutex);
		handler[id].reset_func = wdt_reset;

Admin message