Commit 6a8c521c authored Nov 03, 2019 by Hans Verkuil Committed by Mauro Carvalho Chehab Nov 05, 2019

media: am437x: fix smatch warning



Fixes this warning:

drivers/media/platform/am437x/am437x-vpfe.c:288 vpfe_ccdc_validate_param() warn: unsigned 'ccdcparam->alaw.gamma_wd' is never less than zero.

by dropping the gamma_wd < VPFE_CCDC_GAMMA_BITS_15_6 check
since VPFE_CCDC_GAMMA_BITS_15_6 is 0.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

parent 8ffd573c

drivers/media/platform/am437x/am437x-vpfe.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -285,7 +285,6 @@ vpfe_ccdc_validate_param(struct vpfe_ccdc *ccdc,
		max_data = ccdc_data_size_max_bit(ccdcparam->data_sz);

		if (ccdcparam->alaw.gamma_wd > VPFE_CCDC_GAMMA_BITS_09_0 \|\|
		ccdcparam->alaw.gamma_wd < VPFE_CCDC_GAMMA_BITS_15_6 \|\|
		max_gamma > max_data) {
		vpfe_dbg(1, vpfe, "Invalid data line select\n");
		return -EINVAL;

Admin message