Commit c3d6a0a3 authored by Jingoo Han's avatar Jingoo Han Committed by Samuel Ortiz
Browse files

mfd: twl4030-madc: Remove unnecessary platform_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 96ac2d1a

drivers/mfd/twl4030-madc.c

+1 −4
Original line number Diff line number Diff line
@@ -775,12 +775,10 @@ static int twl4030_madc_probe(struct platform_device *pdev) 
				   IRQF_TRIGGER_RISING, "twl4030_madc", madc);

	if (ret) {

		dev_dbg(&pdev->dev, "could not request irq\n");

		goto err_irq;

		goto err_i2c;

	}

	twl4030_madc = madc;

	return 0;

err_irq:

	platform_set_drvdata(pdev, NULL);

err_i2c:

	twl4030_madc_set_current_generator(madc, 0, 0);

err_current_generator:
@@ -796,7 +794,6 @@ static int twl4030_madc_remove(struct platform_device *pdev) 
	struct twl4030_madc_data *madc = platform_get_drvdata(pdev);



	free_irq(platform_get_irq(pdev, 0), madc);

	platform_set_drvdata(pdev, NULL);

	twl4030_madc_set_current_generator(madc, 0, 0);

	twl4030_madc_set_power(madc, 0);

	kfree(madc);

CRA Git | Maintained and supported by SUSTech CRA and CCSE