Commit 96ac2d1a authored May 06, 2013 by Jingoo Han Committed by Samuel Ortiz Jun 11, 2013

mfd: twl4030-audio: Remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent 9f74f5b5

drivers/mfd/twl4030-audio.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -261,10 +261,8 @@ static int twl4030_audio_probe(struct platform_device *pdev)
		ret = -ENODEV;
		}

		if (ret) {
		platform_set_drvdata(pdev, NULL);
		if (ret)
		twl4030_audio_dev = NULL;
		}

		return ret;
		}
		@@ -272,7 +270,6 @@ static int twl4030_audio_probe(struct platform_device *pdev)
		static int twl4030_audio_remove(struct platform_device *pdev)
		{
		mfd_remove_devices(&pdev->dev);
		platform_set_drvdata(pdev, NULL);
		twl4030_audio_dev = NULL;

		return 0;

Admin message