Commit 9f74f5b5 authored May 06, 2013 by Jingoo Han Committed by Samuel Ortiz Jun 11, 2013

mfd: jz4740-adc: Remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent 7d71cf29

drivers/mfd/jz4740-adc.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -294,7 +294,6 @@ static int jz4740_adc_probe(struct platform_device *pdev)
		err_clk_put:
		clk_put(adc->clk);
		err_iounmap:
		platform_set_drvdata(pdev, NULL);
		iounmap(adc->base);
		err_release_mem_region:
		release_mem_region(adc->mem->start, resource_size(adc->mem));
		@@ -317,8 +316,6 @@ static int jz4740_adc_remove(struct platform_device *pdev)

		clk_put(adc->clk);

		platform_set_drvdata(pdev, NULL);

		return 0;
		}

Admin message