rtc: sc27xx: remove .remove (c202ec09) · Commits · 戴 / test

dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Link: https://lore.kernel.org/r/20191021155806.3625-4-alexandre.belloni@bootlin.com Reviewed-by:

Baolin Wang <baolin.wang@linaro.org> Signed-off-by:

Alexandre Belloni <alexandre.belloni@bootlin.com>

drivers/rtc/rtc-sc27xx.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -661,12 +661,6 @@ static int sprd_rtc_probe(struct platform_device *pdev)
		return 0;
		}

		static int sprd_rtc_remove(struct platform_device *pdev)
		{
		device_init_wakeup(&pdev->dev, 0);
		return 0;
		}

		static const struct of_device_id sprd_rtc_of_match[] = {
		{ .compatible = "sprd,sc2731-rtc", },
		{ },
		@@ -679,7 +673,6 @@ static struct platform_driver sprd_rtc_driver = {
		.of_match_table = sprd_rtc_of_match,
		},
		.probe = sprd_rtc_probe,
		.remove = sprd_rtc_remove,
		};
		module_platform_driver(sprd_rtc_driver);

Admin message