rtc: lpc32xx: remove .remove (aef069a2) · Commits · 戴 / test

dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Link: https://lore.kernel.org/r/20191021155806.3625-2-alexandre.belloni@bootlin.com Signed-off-by:

Alexandre Belloni <alexandre.belloni@bootlin.com>

drivers/rtc/rtc-lpc32xx.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -264,16 +264,6 @@ static int lpc32xx_rtc_probe(struct platform_device *pdev)
		return 0;
		}

		static int lpc32xx_rtc_remove(struct platform_device *pdev)
		{
		struct lpc32xx_rtc *rtc = platform_get_drvdata(pdev);

		if (rtc->irq >= 0)
		device_init_wakeup(&pdev->dev, 0);

		return 0;
		}

		#ifdef CONFIG_PM
		static int lpc32xx_rtc_suspend(struct device *dev)
		{
		@@ -355,7 +345,6 @@ MODULE_DEVICE_TABLE(of, lpc32xx_rtc_match);

		static struct platform_driver lpc32xx_rtc_driver = {
		.probe = lpc32xx_rtc_probe,
		.remove = lpc32xx_rtc_remove,
		.driver = {
		.name = "rtc-lpc32xx",
		.pm = LPC32XX_RTC_PM_OPS,

Admin message