rtc: ab-b5ze-s3: remove .remove (daa2695f) · Commits · 戴 / test

dpm_sysfs_remove() and device_pm_remove() are already called by device_del() on device removal so there is no need to call device_init_wakeup(dev, false) from the driver and it allows to remove the .remove callback. Link: https://lore.kernel.org/r/20191021155806.3625-1-alexandre.belloni@bootlin.com Signed-off-by:

Alexandre Belloni <alexandre.belloni@bootlin.com>

drivers/rtc/rtc-ab-b5ze-s3.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -900,16 +900,6 @@ err:
		return ret;
		}

		static int abb5zes3_remove(struct i2c_client *client)
		{
		struct abb5zes3_rtc_data *rtc_data = dev_get_drvdata(&client->dev);

		if (rtc_data->irq > 0)
		device_init_wakeup(&client->dev, false);

		return 0;
		}

		#ifdef CONFIG_PM_SLEEP
		static int abb5zes3_rtc_suspend(struct device *dev)
		{
		@@ -956,7 +946,6 @@ static struct i2c_driver abb5zes3_driver = {
		.of_match_table = of_match_ptr(abb5zes3_dt_match),
		},
		.probe = abb5zes3_probe,
		.remove = abb5zes3_remove,
		.id_table = abb5zes3_id,
		};
		module_i2c_driver(abb5zes3_driver);

Admin message