Unverified Commit c088a498 authored Nov 06, 2020 by Pi-Hsun Shih Committed by Mark Brown Nov 10, 2020

regulator: core: don't disable regulator if is_enabled return error.



In regulator_late_cleanup when is_enabled failed, don't try to disable
the regulator since it would likely to fail too and causing confusing
error messages.

Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Link: https://lore.kernel.org/r/20201106064817.3290927-1-pihsun@chromium.org


Signed-off-by: Mark Brown <broonie@kernel.org>

parent cf1ad559

drivers/regulator/core.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -5843,13 +5843,14 @@ static int regulator_late_cleanup(struct device dev, void data)
		if (rdev->use_count)
		goto unlock;

		/* If we can't read the status assume it's on. */
		/* If we can't read the status assume it's always on. */
		if (ops->is_enabled)
		enabled = ops->is_enabled(rdev);
		else
		enabled = 1;

		if (!enabled)
		/* But if reading the status failed, assume that it's off. */
		if (enabled <= 0)
		goto unlock;

		if (have_full_constraints()) {

Admin message