Unverified Commit cf1ad559 authored Nov 02, 2020 by Michał Mirosław Committed by Mark Brown Nov 03, 2020

regulator: defer probe when trying to get voltage from unresolved supply



regulator_get_voltage_rdev() is called in regulator probe() when
applying machine constraints.  The "fixed" commit exposed the problem
that non-bypassed regulators can forward the request to its parent
(like bypassed ones) supply. Return -EPROBE_DEFER when the supply
is expected but not resolved yet.

Fixes: aea6cb99 ("regulator: resolve supply after creating regulator")
Cc: stable@vger.kernel.org
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Reported-by: Ondřej Jirman <megous@megous.com>
Reported-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Ondřej Jirman <megous@megous.com>
Link: https://lore.kernel.org/r/a9041d68b4d35e4a2dd71629c8a6422662acb5ee.1604351936.git.mirq-linux@rere.qmqm.pl


Signed-off-by: Mark Brown <broonie@kernel.org>

parent f59cddd8

drivers/regulator/core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -4165,6 +4165,8 @@ int regulator_get_voltage_rdev(struct regulator_dev *rdev)
		ret = rdev->desc->fixed_uV;
		} else if (rdev->supply) {
		ret = regulator_get_voltage_rdev(rdev->supply->rdev);
		} else if (rdev->supply_name) {
		return -EPROBE_DEFER;
		} else {
		return -EINVAL;
		}

Admin message