Commit be576734 authored Oct 11, 2019 by Greg Kroah-Hartman

ntb: ntb_pingpong: no need to check the return value of debugfs calls

There is no need to check the return value of debugfs_create_atomic_t as
nothing happens with the error.  Also, the code will never return NULL,
so this check has never caught anything :)

Fix this by removing the check entirely.

Cc: Jon Mason <jdmason@kudzu.us>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Allen Hubbe <allenbh@gmail.com>
Cc: linux-ntb@googlegroups.com
Cc: linux-kernel@vger.kernel.org
Link: https://lore.kernel.org/r/20191011131919.GA1174815@kroah.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8e580263

drivers/ntb/test/ntb_pingpong.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -354,13 +354,10 @@ static void pp_clear_ctx(struct pp_ctx *pp)
		static void pp_setup_dbgfs(struct pp_ctx *pp)
		{
		struct pci_dev *pdev = pp->ntb->pdev;
		void *ret;

		pp->dbgfs_dir = debugfs_create_dir(pci_name(pdev), pp_dbgfs_topdir);

		ret = debugfs_create_atomic_t("count", 0600, pp->dbgfs_dir, &pp->count);
		if (!ret)
		dev_warn(&pp->ntb->dev, "DebugFS unsupported\n");
		debugfs_create_atomic_t("count", 0600, pp->dbgfs_dir, &pp->count);
		}

		static void pp_clear_dbgfs(struct pp_ctx *pp)

Admin message