Commit 8e580263 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

debugfs: remove return value of debugfs_create_size_t() 



No one checks the return value of debugfs_create_size_t(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20191011132931.1186197-4-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ad26221f

Documentation/filesystems/debugfs.txt

+2 −3
Original line number Diff line number Diff line
@@ -96,9 +96,8 @@ value to be exported. Some types can have different widths on different 
architectures, though, complicating the situation somewhat.  There is a

function meant to help out in one special case:



    struct dentry *debugfs_create_size_t(const char *name, umode_t mode,

				         struct dentry *parent, 

					 size_t *value);

    void debugfs_create_size_t(const char *name, umode_t mode,

			       struct dentry *parent, size_t *value);



As might be expected, this function will create a debugfs file to represent

a variable of type size_t.

fs/debugfs/file.c

+4 −5
Original line number Diff line number Diff line
@@ -721,12 +721,11 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_size_t_wo, NULL, debugfs_size_t_set, "%llu\n"); 
 * @value: a pointer to the variable that the file should read to and write

 *         from.

 */

struct dentry *debugfs_create_size_t(const char *name, umode_t mode,

void debugfs_create_size_t(const char *name, umode_t mode,

			   struct dentry *parent, size_t *value)

{

	return debugfs_create_mode_unsafe(name, mode, parent, value,

					&fops_size_t, &fops_size_t_ro,

					&fops_size_t_wo);

	debugfs_create_mode_unsafe(name, mode, parent, value, &fops_size_t,

				   &fops_size_t_ro, &fops_size_t_wo);

}

EXPORT_SYMBOL_GPL(debugfs_create_size_t);

include/linux/debugfs.h

+5 −8
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ struct dentry *debugfs_create_x32(const char *name, umode_t mode, 
				  struct dentry *parent, u32 *value);

struct dentry *debugfs_create_x64(const char *name, umode_t mode,

				  struct dentry *parent, u64 *value);

struct dentry *debugfs_create_size_t(const char *name, umode_t mode,

void debugfs_create_size_t(const char *name, umode_t mode,

			   struct dentry *parent, size_t *value);

struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,

				     struct dentry *parent, atomic_t *value);
@@ -296,12 +296,9 @@ static inline struct dentry *debugfs_create_x64(const char *name, umode_t mode, 
	return ERR_PTR(-ENODEV);

}



static inline struct dentry *debugfs_create_size_t(const char *name, umode_t mode,

				     struct dentry *parent,

				     size_t *value)

{

	return ERR_PTR(-ENODEV);

}

static inline void debugfs_create_size_t(const char *name, umode_t mode,

					 struct dentry *parent, size_t *value)

{ }



static inline struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode,

				     struct dentry *parent, atomic_t *value)

CRA Git | Maintained and supported by SUSTech CRA and CCSE