Commit ad26221f authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

debugfs: remove return value of debugfs_create_u64() 



No one checks the return value of debugfs_create_u64(), as it's not
needed, so make the return value void, so that no one tries to do so in
the future.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20191011132931.1186197-3-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 313f5dbb

Documentation/filesystems/debugfs.txt

+2 −2
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ created with any of: 
			    struct dentry *parent, u16 *value);

    struct dentry *debugfs_create_u32(const char *name, umode_t mode,

				      struct dentry *parent, u32 *value);

    struct dentry *debugfs_create_u64(const char *name, umode_t mode,

    void debugfs_create_u64(const char *name, umode_t mode,

			    struct dentry *parent, u64 *value);



These files support both reading and writing the given value; if a specific

fs/debugfs/file.c

+3 −12
Original line number Diff line number Diff line
@@ -538,20 +538,11 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_u64_wo, NULL, debugfs_u64_set, "%llu\n"); 
 * This function creates a file in debugfs with the given name that

 * contains the value of the variable @value.  If the @mode variable is so

 * set, it can be read from, and written to.

 *

 * This function will return a pointer to a dentry if it succeeds.  This

 * pointer must be passed to the debugfs_remove() function when the file is

 * to be removed (no automatic cleanup happens if your module is unloaded,

 * you are responsible here.)  If an error occurs, %ERR_PTR(-ERROR) will be

 * returned.

 *

 * If debugfs is not enabled in the kernel, the value %ERR_PTR(-ENODEV) will

 * be returned.

 */

struct dentry *debugfs_create_u64(const char *name, umode_t mode,

				 struct dentry *parent, u64 *value)

void debugfs_create_u64(const char *name, umode_t mode, struct dentry *parent,

			u64 *value)

{

	return debugfs_create_mode_unsafe(name, mode, parent, value, &fops_u64,

	debugfs_create_mode_unsafe(name, mode, parent, value, &fops_u64,

				   &fops_u64_ro, &fops_u64_wo);

}

EXPORT_SYMBOL_GPL(debugfs_create_u64);

include/linux/debugfs.h

+4 −8
Original line number Diff line number Diff line
@@ -103,8 +103,8 @@ void debugfs_create_u16(const char *name, umode_t mode, struct dentry *parent, 
			u16 *value);

struct dentry *debugfs_create_u32(const char *name, umode_t mode,

				  struct dentry *parent, u32 *value);

struct dentry *debugfs_create_u64(const char *name, umode_t mode,

				  struct dentry *parent, u64 *value);

void debugfs_create_u64(const char *name, umode_t mode, struct dentry *parent,

			u64 *value);

struct dentry *debugfs_create_ulong(const char *name, umode_t mode,

				    struct dentry *parent, unsigned long *value);

struct dentry *debugfs_create_x8(const char *name, umode_t mode,
@@ -257,12 +257,8 @@ static inline struct dentry *debugfs_create_u32(const char *name, umode_t mode, 
	return ERR_PTR(-ENODEV);

}



static inline struct dentry *debugfs_create_u64(const char *name, umode_t mode,

						struct dentry *parent,

						u64 *value)

{

	return ERR_PTR(-ENODEV);

}

static inline void debugfs_create_u64(const char *name, umode_t mode,

				      struct dentry *parent, u64 *value) { }



static inline struct dentry *debugfs_create_ulong(const char *name,

						umode_t mode,

CRA Git | Maintained and supported by SUSTech CRA and CCSE