Commit bb0967c0 authored Jun 25, 2020 by Jeff Kirsher Committed by Tony Nguyen Jul 01, 2020

ixgbe: Cleanup unneeded delay in ethtool test



There is a 4 seconds delay in ixgbe_diag_test() that is holding up other
ioctls such as SIOCGIFCONF that Oracle database applications use.
One of Oracle's product runs "ethtool -t ethX online" periodically for
system monitoring and that is impacting database applications that use
SIOCGIFCONF at that same time.

This 4 second delay was needed in out early 1GbE parts to give the PHY
time to recover from a reset.  This code was carried forward to the 10 GbE
driver even it was not needed for the supported PHYs in the ixgbe driver.

CC: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
CC: Jack Vogel <jack.vogel@oracle.com>
Reported-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

parent 93580766

drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c

+1 −4

Original line number	Original line	Diff line number	Diff line
	@@ -2084,7 +2084,7 @@ static void ixgbe_diag_test(struct net_device *netdev,
	eth_test->flags \|= ETH_TEST_FL_FAILED;		eth_test->flags \|= ETH_TEST_FL_FAILED;
	clear_bit(__IXGBE_TESTING,		clear_bit(__IXGBE_TESTING,
	&adapter->state);		&adapter->state);
	goto skip_ol_tests;		return;
	}		}
	}		}
	}		}
	@@ -2156,9 +2156,6 @@ skip_loopback:

	clear_bit(__IXGBE_TESTING, &adapter->state);		clear_bit(__IXGBE_TESTING, &adapter->state);
	}		}

	skip_ol_tests:
	msleep_interruptible(4 * 1000);
	}		}

	static int ixgbe_wol_exclusion(struct ixgbe_adapter *adapter,		static int ixgbe_wol_exclusion(struct ixgbe_adapter *adapter,

Admin message