Commit 93580766 authored Jun 24, 2020 by Tony Nguyen

iavf: Fix updating statistics

Commit bac84861 ("iavf: Refactor the watchdog state machine") inverted
the logic for when to update statistics. Statistics should be updated when
no other commands are pending, instead they were only requested when a
command was processed. iavf_request_stats() would see a pending request
and not request statistics to be updated. This caused statistics to never
be updated; fix the logic.

Fixes: bac84861 ("iavf: Refactor the watchdog state machine")
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

parent 44ea803e

drivers/net/ethernet/intel/iavf/iavf_main.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1937,7 +1937,10 @@ static void iavf_watchdog_task(struct work_struct *work)
		iavf_send_api_ver(adapter);
		}
		} else {
		if (!iavf_process_aq_command(adapter) &&
		/* An error will be returned if no commands were
		* processed; use this opportunity to update stats
		*/
		if (iavf_process_aq_command(adapter) &&
		adapter->state == __IAVF_RUNNING)
		iavf_request_stats(adapter);
		}

Admin message