Commit b92103b5 authored Mar 03, 2020 by Ralph Campbell Committed by Ben Skeggs Apr 07, 2020

drm/nouveau/svm: fix vma range check for migration



find_vma_intersection(mm, start, end) only guarantees that end is greater
than or equal to vma->vm_start but doesn't guarantee that start is
greater than or equal to vma->vm_start. The calculation for the
intersecting range in nouveau_svmm_bind() isn't accounting for this and
can call migrate_vma_setup() with a starting address less than
vma->vm_start. This results in migrate_vma_setup() returning -EINVAL for
the range instead of nouveau skipping that part of the range and migrating
the rest.

Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent e18c6e8b

drivers/gpu/drm/nouveau/nouveau_svm.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -179,6 +179,7 @@ nouveau_svmm_bind(struct drm_device dev, void data,
		if (!vma)
		break;

		addr = max(addr, vma->vm_start);
		next = min(vma->vm_end, end);
		/* This is a best effort so we ignore errors */
		nouveau_dmem_migrate_vma(cli->drm, vma, addr, next);

Admin message