drm/nouveau: remove checks for return value of debugfs functions (e18c6e8b) · Commits · 戴 / test

As there is no need to check for the return value of debugfs_create_file and drm_debugfs_create_files, remove unnecessary checks and error handling in nouveau_drm_debugfs_init. Signed-off-by:

Wambui Karuga <wambui.karugax@gmail.com> Signed-off-by:

Ben Skeggs <bskeggs@redhat.com>

drivers/gpu/drm/nouveau/nouveau_debugfs.c

+8 −12

Original line number	Diff line number	Diff line
		@@ -222,22 +222,18 @@ nouveau_drm_debugfs_init(struct drm_minor *minor)
		{
		struct nouveau_drm *drm = nouveau_drm(minor->dev);
		struct dentry *dentry;
		int i, ret;
		int i;

		for (i = 0; i < ARRAY_SIZE(nouveau_debugfs_files); i++) {
		dentry = debugfs_create_file(nouveau_debugfs_files[i].name,
		debugfs_create_file(nouveau_debugfs_files[i].name,
		S_IRUGO \| S_IWUSR,
		minor->debugfs_root, minor->dev,
		nouveau_debugfs_files[i].fops);
		if (!dentry)
		return -ENOMEM;
		}

		ret = drm_debugfs_create_files(nouveau_debugfs_list,
		drm_debugfs_create_files(nouveau_debugfs_list,
		NOUVEAU_DEBUGFS_ENTRIES,
		minor->debugfs_root, minor);
		if (ret)
		return ret;

		/* Set the size of the vbios since we know it, and it's confusing to
		* userspace if it wants to seek() but the file has a length of 0

Admin message