Commit b919e077 authored May 06, 2020 by Wei Yongjun Committed by Greg Kroah-Hartman May 13, 2020

USB: ohci-sm501: fix error return code in ohci_hcd_sm501_drv_probe()



Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 7d9e6f5a ("usb: host: ohci-sm501: init genalloc for local memory")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200506135625.106910-1-weiyongjun1@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent c856b4b0

drivers/usb/host/ohci-sm501.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -157,9 +157,10 @@ static int ohci_hcd_sm501_drv_probe(struct platform_device *pdev)
		* the call to usb_hcd_setup_local_mem() below does just that.
		*/

		if (usb_hcd_setup_local_mem(hcd, mem->start,
		retval = usb_hcd_setup_local_mem(hcd, mem->start,
		mem->start - mem->parent->start,
		resource_size(mem)) < 0)
		resource_size(mem));
		if (retval < 0)
		goto err5;
		retval = usb_add_hcd(hcd, irq, IRQF_SHARED);
		if (retval)

Admin message