Commit c856b4b0 authored May 08, 2020 by Tang Bin Committed by Greg Kroah-Hartman May 13, 2020

USB: EHCI: ehci-mv: fix error handling in mv_ehci_probe()



If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
mv_ehci_probe(). And when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20200508114305.15740-1-tangbin@cmss.chinamobile.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 09806eba

drivers/usb/host/ehci-mv.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -167,9 +167,8 @@ static int mv_ehci_probe(struct platform_device *pdev)
		hcd->regs = ehci_mv->op_regs;

		hcd->irq = platform_get_irq(pdev, 0);
		if (!hcd->irq) {
		dev_err(&pdev->dev, "Cannot get irq.");
		retval = -ENODEV;
		if (hcd->irq < 0) {
		retval = hcd->irq;
		goto err_disable_clk;
		}

Admin message