net: stmmac: selftests: Check if filtering is available before running (b870b0f8) · Commits · 戴 / test

We need to check if the number of available Hash Filters is enough to run the test, otherwise we will get false failures. Fixes: ("net: stmmac: Introduce selftests support") Signed-off-by:

Jose Abreu <Jose.Abreu@synopsys.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -496,6 +496,9 @@ static int stmmac_test_hfilt(struct stmmac_priv *priv)
		if (ret)
		return ret;

		if (netdev_mc_count(priv->dev) >= priv->hw->multicast_filter_bins)
		return -EOPNOTSUPP;

		ret = dev_mc_add(priv->dev, gd_addr);
		if (ret)
		return ret;
		@@ -573,6 +576,8 @@ static int stmmac_test_mcfilt(struct stmmac_priv *priv)

		if (stmmac_filter_check(priv))
		return -EOPNOTSUPP;
		if (!priv->hw->multicast_filter_bins)
		return -EOPNOTSUPP;

		/* Remove all MC addresses */
		__dev_mc_unsync(priv->dev, NULL);
		@@ -611,6 +616,8 @@ static int stmmac_test_ucfilt(struct stmmac_priv *priv)

		if (stmmac_filter_check(priv))
		return -EOPNOTSUPP;
		if (!priv->hw->multicast_filter_bins)
		return -EOPNOTSUPP;

		/* Remove all UC addresses */
		__dev_uc_unsync(priv->dev, NULL);

Admin message