Commit c763ac43 authored Oct 05, 2019 by Florian Fainelli Committed by David S. Miller Oct 06, 2019

net: dsa: b53: Do not clear existing mirrored port mask



Clearing the existing bitmask of mirrored ports essentially prevents us
from capturing more than one port at any given time. This is clearly
wrong, do not clear the bitmask prior to setting up the new port.

Reported-by: Hubert Feurstein <h.feurstein@gmail.com>
Fixes: ed3af5fd ("net: dsa: b53: Add support for port mirroring")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2d00aee2

drivers/net/dsa/b53/b53_common.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1845,7 +1845,6 @@ int b53_mirror_add(struct dsa_switch *ds, int port,
		loc = B53_EG_MIR_CTL;

		b53_read16(dev, B53_MGMT_PAGE, loc, &reg);
		reg &= ~MIRROR_MASK;
		reg \|= BIT(port);
		b53_write16(dev, B53_MGMT_PAGE, loc, reg);

Admin message