Commit b7d6df57 authored Apr 24, 2017 by Paolo Abeni Committed by David S. Miller Apr 25, 2017

ipv6: move stub initialization after ipv6 setup completion



The ipv6 stub pointer is currently initialized before the ipv6
routing subsystem: a 3rd party can access and use such stub
before the routing data is ready.
Moreover, such pointer is not cleared in case of initialization
error, possibly leading to dangling pointers usage.

This change addresses the above moving the stub initialization
at the end of ipv6 init code.

Fixes: 5f81bd2e ("ipv6: export a stub for IPv6 symbols used by vxlan")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 72ec0bc6

net/ipv6/af_inet6.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -933,8 +933,6 @@ static int __init inet6_init(void)
		if (err)
		goto igmp_fail;

		ipv6_stub = &ipv6_stub_impl;

		err = ipv6_netfilter_init();
		if (err)
		goto netfilter_fail;
		@@ -1010,6 +1008,10 @@ static int __init inet6_init(void)
		if (err)
		goto sysctl_fail;
		#endif

		/* ensure that ipv6 stubs are visible only after ipv6 is ready */
		wmb();
		ipv6_stub = &ipv6_stub_impl;
		out:
		return err;

Admin message