team: fix memory leaks (72ec0bc6) · Commits · 戴 / test

In functions team_nl_send_port_list_get() and team_nl_send_options_get(), pointer skb keeps the return value of nlmsg_new(). When the call to genlmsg_put() fails, the memory is not freed(). This will result in memory leak bugs. Fixes: ("team: implement multipart netlink messages for options transfers") Signed-off-by:

Pan Bian <bianpan2016@163.com> Acked-by:

Jiri Pirko <jiri@mellanox.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/team/team.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -2361,8 +2361,10 @@ start_again:

		hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags \| NLM_F_MULTI,
		TEAM_CMD_OPTIONS_GET);
		if (!hdr)
		if (!hdr) {
		nlmsg_free(skb);
		return -EMSGSIZE;
		}

		if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex))
		goto nla_put_failure;
		@@ -2634,8 +2636,10 @@ start_again:

		hdr = genlmsg_put(skb, portid, seq, &team_nl_family, flags \| NLM_F_MULTI,
		TEAM_CMD_PORT_LIST_GET);
		if (!hdr)
		if (!hdr) {
		nlmsg_free(skb);
		return -EMSGSIZE;
		}

		if (nla_put_u32(skb, TEAM_ATTR_TEAM_IFINDEX, team->dev->ifindex))
		goto nla_put_failure;

Admin message