Commit b608f11d authored Sep 23, 2020 by Stephen Boyd

clk: rockchip: Initialize hw to error to avoid undefined behavior



We can get down to this return value from ERR_CAST() without
initializing hw. Set it to -ENOMEM so that we always return something
sane.

Fixes the following smatch warning:

drivers/clk/rockchip/clk-half-divider.c:228 rockchip_clk_register_halfdiv() error: uninitialized symbol 'hw'.
drivers/clk/rockchip/clk-half-divider.c:228 rockchip_clk_register_halfdiv() warn: passing zero to 'ERR_CAST'

Cc: Elaine Zhang <zhangqing@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Fixes: 956060a5 ("clk: rockchip: add support for half divider")
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent ca52a47a

drivers/clk/rockchip/clk-half-divider.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -166,7 +166,7 @@ struct clk rockchip_clk_register_halfdiv(const char name,
		unsigned long flags,
		spinlock_t *lock)
		{
		struct clk_hw *hw;
		struct clk_hw *hw = ERR_PTR(-ENOMEM);
		struct clk_mux *mux = NULL;
		struct clk_gate *gate = NULL;
		struct clk_divider *div = NULL;

Admin message