mptcp/pm_netlink.c : add check for nla_put_in/6_addr (b4e0f9a9) · Commits · 戴 / test

Normal there should be checked for nla_put_in6_addr like other usage in net. Detected by CoverityScan, CID# 1461639 Fixes: ("mptcp: add netlink-based PM") Signed-off-by:

Bo YU <tsu.yubo@gmail.com> Acked-by:

Paolo Abeni <pabeni@redhat.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/mptcp/pm_netlink.c

+7 −5

Original line number	Diff line number	Diff line
		@@ -599,12 +599,14 @@ static int mptcp_nl_fill_addr(struct sk_buff *skb,
		nla_put_s32(skb, MPTCP_PM_ADDR_ATTR_IF_IDX, entry->ifindex))
		goto nla_put_failure;

		if (addr->family == AF_INET)
		if (addr->family == AF_INET &&
		nla_put_in_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR4,
		addr->addr.s_addr);
		addr->addr.s_addr))
		goto nla_put_failure;
		#if IS_ENABLED(CONFIG_MPTCP_IPV6)
		else if (addr->family == AF_INET6)
		nla_put_in6_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR6, &addr->addr6);
		else if (addr->family == AF_INET6 &&
		nla_put_in6_addr(skb, MPTCP_PM_ADDR_ATTR_ADDR6, &addr->addr6))
		goto nla_put_failure;
		#endif
		nla_nest_end(skb, attr);
		return 0;

Admin message