Commit 6ed79cec authored Apr 23, 2020 by Tang Bin Committed by David S. Miller Apr 23, 2020

net: ethernet: ixp4xx: Add error handling in ixp4xx_eth_probe()

The function ixp4xx_eth_probe() does not perform sufficient error
checking after executing devm_ioremap_resource(), which can result
in crashes if a critical error path is encountered.

Fixes: f458ac47 ("ARM/net: ixp4xx: Pass ethernet physical base as resource")
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ce222748

drivers/net/ethernet/xscale/ixp4xx_eth.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1387,6 +1387,8 @@ static int ixp4xx_eth_probe(struct platform_device *pdev)
		return -ENODEV;
		regs_phys = res->start;
		port->regs = devm_ioremap_resource(dev, res);
		if (IS_ERR(port->regs))
		return PTR_ERR(port->regs);

		switch (port->id) {
		case IXP4XX_ETH_NPEA: