Commit b45649fb authored by Dhinakaran Pandiyan's avatar Dhinakaran Pandiyan
Browse files

drm/i915: Do not advertize support for NV12 on ICL yet. 



ICL requires two planes for scanning out a NV12 framebuffer. Do
not advertize support for creating NV12 framebuffers until required
plane programming is implemented.

v2: Do not allow adding buffers.
    Check inside skl_plane_has_planar (Ville)

Bspec: Plane Planar YUV programming (18566)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180824203856.17700-2-dhinakaran.pandiyan@intel.com
parent 18563409

drivers/gpu/drm/i915/intel_display.c

+8 −1
Original line number Diff line number Diff line
@@ -13619,6 +13619,13 @@ static bool skl_plane_has_fbc(struct drm_i915_private *dev_priv, 
bool skl_plane_has_planar(struct drm_i915_private *dev_priv,

			  enum pipe pipe, enum plane_id plane_id)

{

	/*

	 * FIXME: ICL requires two hardware planes for scanning out NV12

	 * framebuffers. Do not advertize support until this is implemented.

	 */

	if (INTEL_GEN(dev_priv) >= 11)

		return false;



	if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))

		return false;
@@ -14540,7 +14547,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb, 
		break;

	case DRM_FORMAT_NV12:

		if (INTEL_GEN(dev_priv) < 9 || IS_SKYLAKE(dev_priv) ||

		    IS_BROXTON(dev_priv)) {

		    IS_BROXTON(dev_priv) || INTEL_GEN(dev_priv) >= 11) {

			DRM_DEBUG_KMS("unsupported pixel format: %s\n",

				      drm_get_format_name(mode_cmd->pixel_format,

							  &format_name));

CRA Git | Maintained and supported by SUSTech CRA and CCSE